Skip to content

Mark 5xx status codes as an error#261

Merged
realark merged 3 commits into
masterfrom
ark/500_errors
Mar 13, 2018
Merged

Mark 5xx status codes as an error#261
realark merged 3 commits into
masterfrom
ark/500_errors

Conversation

@realark
Copy link
Copy Markdown
Contributor

@realark realark commented Mar 13, 2018 •
edited
Loading

  • Mark all spans with 5xx status code as an error
  • Use bultin decorators for all instances of DDTracer

@realark realark added the type: bug Bug report and fix label Mar 13, 2018
@realark realark changed the title Ark/500 errors Mark 5xx status codes as an error Mar 13, 2018
@realark realark requested a review from tylerbenson March 13, 2018 17:56
@realark realark added this to the 0.5.0 milestone Mar 13, 2018
tylerbenson
tylerbenson approved these changes Mar 13, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would you mind merging #260 first and rebasing? Thanks!

@realark realark merged commit 5edd65d into master Mar 13, 2018
@realark realark deleted the ark/500_errors branch March 13, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tylerbenson tylerbenson tylerbenson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: bug Bug report and fix

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@realark @tylerbenson